Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds deletion endpoints to service #18

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Adds deletion endpoints to service #18

merged 4 commits into from
Jan 16, 2024

Conversation

bomoko
Copy link
Collaborator

@bomoko bomoko commented Dec 14, 2023

closes #17

This PR introduces four new endpoints and a new pair of message types

  • direct.delete.facts
  • direct.delete.problems

Both send a message of the following structure to insights-handler

type DirectDeleteMessage struct {
	Type          string `json:"type"`
	EnvironmentId int    `json:"environmentId"`
	Source        string `json:"source"`
	Service       string `json:"service"`
}

This is used to drive the deletion of insights for an environment - with Service being optional.

Essentially these mirror the deleteProblemsFromSource and deleteFactsFromSource Lagoon core api calls.

@bomoko bomoko requested a review from CGoodwin90 December 15, 2023 01:05
@bomoko bomoko merged commit 285986e into main Jan 16, 2024
2 checks passed
@bomoko bomoko deleted the feature/addsDeletion branch February 25, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support clearing facts/problems
2 participants